Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logdb filter #774

Merged
merged 3 commits into from
Jun 14, 2024
Merged

Update logdb filter #774

merged 3 commits into from
Jun 14, 2024

Conversation

otherview
Copy link
Member

Description

Limits the log db result size to 1000 entries.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

unit tests

Test Configuration:

  • Go Version:
  • Hardware:
  • Docker Version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@otherview otherview requested a review from a team as a code owner June 14, 2024 13:05
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.62%. Comparing base (3d7ab12) to head (a96dd23).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #774      +/-   ##
==========================================
+ Coverage   62.58%   62.62%   +0.04%     
==========================================
  Files         199      199              
  Lines       18098    18118      +20     
==========================================
+ Hits        11326    11346      +20     
  Misses       5690     5690              
  Partials     1082     1082              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

paologalligit
paologalligit previously approved these changes Jun 14, 2024
Copy link
Member

@paologalligit paologalligit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only comment maybe the 1k threshold can be named to make it more explicit e.g. limitThreshold = 1000 or something like that

@otherview otherview merged commit c23c19a into master Jun 14, 2024
15 checks passed
@otherview otherview deleted the pedro/update_filter branch June 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants