getsummary and getsummaryAndState decoupling #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #786 +/- ##
==========================================
+ Coverage 62.57% 62.65% +0.08%
==========================================
Files 199 199
Lines 18153 18196 +43
==========================================
+ Hits 11359 11401 +42
Misses 5713 5713
- Partials 1081 1082 +1 ☔ View full report in Codecov by Sentry. |
|
LGTM, this will tidy API in revisions.go, thanks! |
otherview
added a commit
that referenced
this pull request
Jul 11, 2024
) * fix: using the best block + 1 when estimating * fix: update comment * remove duplicate statement * fix: update thor.yaml and change pending to next * refactor: update query param name * fix: use 'next' instead of pending * chore: add unit tests * fix: use next only if explicity defined * fix: update unit tests * new way for parsing revision next (#37) * Update api/doc/thor.yaml Co-authored-by: libotony <[email protected]> * chore: update doc.yaml * Update api/accounts/accounts_test.go Co-authored-by: Darren Kelly <[email protected]> * Update api/debug/debug_test.go * getsummary and getsummaryAndState decoupling (#786) * getsummary and getsummaryAndState decoupling * restart build * switch table tests to array * chore: update thor.yaml and update e2e commit sha * chore: update e2e commit sha --------- Co-authored-by: libotony <[email protected]> Co-authored-by: otherview <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small refactor around getsummary
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration
Test Configuration:
Checklist: