Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

api: return error when the limit options is nil and the filtered logs… #796

Merged
merged 2 commits into from
Jul 23, 2024

Conversation

libotony
Copy link
Member

…ered logs exceeds server configured limit

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@libotony libotony requested a review from a team as a code owner July 23, 2024 05:52
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.09%. Comparing base (e6a0527) to head (d727b6a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #796      +/-   ##
==========================================
- Coverage   62.12%   62.09%   -0.03%     
==========================================
  Files         203      203              
  Lines       18702    18723      +21     
==========================================
+ Hits        11618    11626       +8     
- Misses       5982     5996      +14     
+ Partials     1102     1101       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

darrenvechain
darrenvechain previously approved these changes Jul 23, 2024
@otherview otherview merged commit e6c91cb into master Jul 23, 2024
12 checks passed
@otherview otherview deleted the tony/api_logs_limit branch July 23, 2024 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants