Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VIP :: extension v3 #803

Closed
wants to merge 23 commits into from
Closed

VIP :: extension v3 #803

wants to merge 23 commits into from

Conversation

darrenvechain
Copy link
Member

@darrenvechain darrenvechain commented Jul 26, 2024

Description

This PR should be merged AFTER shanghai, as it includes those code changes
Extend the extension built-in to include clause context: vechain/VIPs#73

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner July 26, 2024 08:51
@darrenvechain darrenvechain changed the title Vip extension v3 VIP :: extension v3 Jul 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 57.61317% with 103 lines in your changes missing coverage. Please review.

Project coverage is 62.55%. Comparing base (e6c91cb) to head (609d4e9).
Report is 38 commits behind head on master.

Files with missing lines Patch % Lines
vm/gas_table.go 8.69% 42 Missing ⚠️
vm/evm.go 65.38% 11 Missing and 7 partials ⚠️
vm/contracts.go 70.00% 14 Missing and 1 partial ⚠️
builtin/extension_native.go 11.11% 8 Missing ⚠️
vm/instructions.go 27.27% 8 Missing ⚠️
vm/interpreter.go 0.00% 5 Missing ⚠️
runtime/runtime.go 55.55% 2 Missing and 2 partials ⚠️
genesis/devnet.go 0.00% 0 Missing and 1 partial ⚠️
vm/gas.go 0.00% 1 Missing ⚠️
xenv/env.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #803      +/-   ##
==========================================
+ Coverage   62.08%   62.55%   +0.46%     
==========================================
  Files         203      203              
  Lines       18723    18824     +101     
==========================================
+ Hits        11624    11775     +151     
+ Misses       5997     5948      -49     
+ Partials     1102     1101       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants