Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the blocks/{ref}/baseGasCoef endpoint #810

Closed
wants to merge 2 commits into from

Conversation

otherview
Copy link
Member

Description

Based of https://github.com/vechain/protocol-board-repo/issues/285

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also
list any relevant details for your test configuration

  • Test A
  • Test B

Test Configuration:

  • Go Version:
  • Hardware:
  • Docker Version:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@otherview otherview requested a review from a team as a code owner August 6, 2024 17:08
@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 64.91228% with 20 lines in your changes missing coverage. Please review.

Project coverage is 62.54%. Comparing base (ff68ae2) to head (887dd47).
Report is 3 commits behind head on master.

Files Patch % Lines
api/blocks/blocks.go 64.91% 11 Missing and 9 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #810      +/-   ##
==========================================
+ Coverage   62.08%   62.54%   +0.46%     
==========================================
  Files         203      203              
  Lines       18723    18780      +57     
==========================================
+ Hits        11624    11746     +122     
+ Misses       5998     5927      -71     
- Partials     1101     1107       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@otherview otherview marked this pull request as draft August 9, 2024 09:04
@otherview
Copy link
Member Author

Not going forward at this time - decision for 3rd parties to provide this data.

@otherview otherview closed this Aug 19, 2024
@otherview otherview deleted the pedro/getBaseGasCoef_endpoint branch August 19, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants