Metrics (Batch writes performance): Bytes written per bulk + duration #937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feat/db #937 +/- ##
===========================================
+ Coverage 61.54% 61.57% +0.03%
===========================================
Files 217 217
Lines 22635 22640 +5
===========================================
+ Hits 13930 13940 +10
+ Misses 7583 7579 -4
+ Partials 1122 1121 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers
Batch Write Performancefrom this ticket https://github.com/vechain/protocol-board-repo/issues/340.Since the leveldb library as such does not return info about this, we set the metrics at the operation level within
engine.