Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vip extension v3 #950

Closed
wants to merge 24 commits into from
Closed

Vip extension v3 #950

wants to merge 24 commits into from

Conversation

darrenvechain
Copy link
Member

Description

Implementation of extension v3

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner January 17, 2025 11:01
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 71.42857% with 10 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/galactica@cf1782c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
builtin/extension_native.go 11.11% 8 Missing ⚠️
genesis/devnet.go 0.00% 0 Missing and 1 partial ⚠️
xenv/env.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/galactica     #950   +/-   ##
====================================================
  Coverage                     ?   60.96%           
====================================================
  Files                        ?      220           
  Lines                        ?    23534           
  Branches                     ?        0           
====================================================
  Hits                         ?    14347           
  Misses                       ?     8020           
  Partials                     ?     1167           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants