Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(builtins): extension v3 #951

Open
wants to merge 5 commits into
base: release/galactica
Choose a base branch
from

Conversation

darrenvechain
Copy link
Member

@darrenvechain darrenvechain commented Jan 17, 2025

Description

Extension v3 Implementation

E2E tests can be found here: vechain/thor-e2e-tests#67

PR is pending e2e PR merge

  • Extension function txExpiration increases gas cost from 388 to 410 after extension updates to v3, not sure whats happening here

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@darrenvechain darrenvechain requested a review from a team as a code owner January 17, 2025 11:04
@darrenvechain darrenvechain marked this pull request as draft January 17, 2025 11:08
@@ -112,6 +112,9 @@ func New(
panic(err)
}
}
if err := state.SetCode(builtin.Extension.Address, builtin.Extension.V3.RuntimeBytecodes()); err != nil {
Copy link
Member Author

@darrenvechain darrenvechain Jan 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will change the solo config. Do we need to explicitly define a solo config now instead of using thor.ForkConfig{} ?

@codecov-commenter
Copy link

codecov-commenter commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 69.23077% with 12 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/galactica@cf1782c). Learn more about missing BASE report.

Files with missing lines Patch % Lines
builtin/extension_native.go 11.11% 8 Missing ⚠️
runtime/runtime.go 50.00% 1 Missing and 2 partials ⚠️
xenv/env.go 88.88% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/galactica     #951   +/-   ##
====================================================
  Coverage                     ?   60.95%           
====================================================
  Files                        ?      220           
  Lines                        ?    23538           
  Branches                     ?        0           
====================================================
  Hits                         ?    14347           
  Misses                       ?     8023           
  Partials                     ?     1168           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@darrenvechain darrenvechain marked this pull request as ready for review January 21, 2025 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants