-
Notifications
You must be signed in to change notification settings - Fork 251
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(builtins): extension v3 #951
base: release/galactica
Are you sure you want to change the base?
Conversation
runtime/runtime.go
Outdated
@@ -112,6 +112,9 @@ func New( | |||
panic(err) | |||
} | |||
} | |||
if err := state.SetCode(builtin.Extension.Address, builtin.Extension.V3.RuntimeBytecodes()); err != nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will change the solo config. Do we need to explicitly define a solo config now instead of using thor.ForkConfig{}
?
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/galactica #951 +/- ##
====================================================
Coverage ? 60.95%
====================================================
Files ? 220
Lines ? 23538
Branches ? 0
====================================================
Hits ? 14347
Misses ? 8023
Partials ? 1168 ☔ View full report in Codecov by Sentry. |
Description
Extension v3 Implementation
E2E tests can be found here: vechain/thor-e2e-tests#67
PR is pending e2e PR merge
txExpiration
increases gas cost from 388 to 410 after extension updates to v3, not sure whats happening hereChecklist: