Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(fix): Update UI steps on how to reset or delete the corpus #404

Merged
merged 3 commits into from
Feb 5, 2025

Conversation

pwoznic
Copy link
Contributor

@pwoznic pwoznic commented Feb 5, 2025

Fixes #402

@pwoznic pwoznic marked this pull request as ready for review February 5, 2025 20:11
Copy link

netlify bot commented Feb 5, 2025

Deploy Preview for luxury-shortbread-acee05 ready!

Name Link
🔨 Latest commit 7c33c95
🔍 Latest deploy log https://app.netlify.com/sites/luxury-shortbread-acee05/deploys/67a3e7155cb1ab00085cf68d
😎 Deploy Preview https://deploy-preview-404--luxury-shortbread-acee05.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@pwoznic pwoznic requested a review from cjcenizal February 5, 2025 20:12
Copy link
Collaborator

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think line 18 refers to a “Reset” action, but that’s called “Clear corpus data” now. Can you fix that bit and any other outdated references?

@pwoznic
Copy link
Contributor Author

pwoznic commented Feb 5, 2025

I made a few more changes.

Copy link
Collaborator

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just had one more suggestion and then I think this is good to go!

@@ -1,26 +1,27 @@
---
id: reset-or-delete-corpus
title: Reset or Delete a Corpus
title: Disable, Clear, or Delete Corpus Data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a little confusingly phrased. We should disambiguate between “clear corpus data” and “delete corpus”.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Clear Corpus Data or Delete a Corpus" or simply just "Manage Corpus Data"?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I think "Delete Corpus, Disable Corpus, and Clear Corpus Data" is clearest, even if it is wordy.

@pwoznic pwoznic merged commit 28a28a5 into vectara:main Feb 5, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Corpus management docs are out of date
2 participants