-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(fix): Update UI steps on how to reset or delete the corpus #404
Conversation
✅ Deploy Preview for luxury-shortbread-acee05 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I think line 18 refers to a “Reset” action, but that’s called “Clear corpus data” now. Can you fix that bit and any other outdated references?
I made a few more changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just had one more suggestion and then I think this is good to go!
@@ -1,26 +1,27 @@ | |||
--- | |||
id: reset-or-delete-corpus | |||
title: Reset or Delete a Corpus | |||
title: Disable, Clear, or Delete Corpus Data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is a little confusingly phrased. We should disambiguate between “clear corpus data” and “delete corpus”.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "Clear Corpus Data or Delete a Corpus" or simply just "Manage Corpus Data"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I think "Delete Corpus, Disable Corpus, and Clear Corpus Data" is clearest, even if it is wordy.
Fixes #402