Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): Update haproxy-alpine to 2.4.17 #218

Merged
merged 5 commits into from
Jun 9, 2022
Merged

chore(deps): Update haproxy-alpine to 2.4.17 #218

merged 5 commits into from
Jun 9, 2022

Conversation

SIPR-octo
Copy link
Contributor

Fixes #217

See the linked issue for more details

@spencergilbert
Copy link
Contributor

Thanks @SIPR-octo do you mind also bumping the patch version and running helm-docs to update the README banner?

@SIPR-octo
Copy link
Contributor Author

SIPR-octo commented Jun 8, 2022 •
edited
Loading

@spencergilbert Just did!

@SIPR-octo
Copy link
Contributor Author

I just updated the Chart version to make the CI jobs pass.
Do I need to update the README as well?

Unsure to what extend I need to modify this, I did not find any CONTRIBUTING.md file :)

@spencergilbert
Copy link
Contributor

Unsure to what extend I need to modify this, I did not find any CONTRIBUTING.md file :)

😅 #204

I've got it - it's normally just been myself making changes so I haven't prioritized a lot of documentation

@spencergilbert spencergilbert enabled auto-merge (squash) June 8, 2022 13:58
auto-merge was automatically disabled June 9, 2022 08:37

Head branch was pushed to by a user without write access

@SIPR-octo
Copy link
Contributor Author

SIPR-octo commented Jun 9, 2022 •
edited
Loading

Just upgraded helm-docs version in CI because it seems you generated the doc with a newer version than the one used in GitHub Actions (tested locally, it works).

I can make 2 separate MR if you wish me to (1 for bumping helm-docs, 1 for haproxy), just let me know.

@spencergilbert spencergilbert enabled auto-merge (squash) June 9, 2022 15:20
@spencergilbert spencergilbert merged commit 5de1026 into vectordotdev:develop Jun 9, 2022
@SIPR-octo SIPR-octo deleted the patch-haproxy branch June 9, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencergilbert spencergilbert spencergilbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

haproxy-alpine image is outdated and contains vulnerabilities
2 participants
@SIPR-octo @spencergilbert