Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(vrl): add docs for new parse_bytes function #22089

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

titaneric
Copy link
Contributor

@titaneric titaneric commented Dec 28, 2024

Summary

This is documents for vectordotdev/vrl#1198

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Dec 28, 2024
@titaneric titaneric marked this pull request as ready for review January 6, 2025 18:05
@titaneric titaneric requested review from a team as code owners January 6, 2025 18:05
@pront pront added this to the Vector v0.44.0 milestone Jan 6, 2025
@pront pront enabled auto-merge January 6, 2025 18:53
@pront pront added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Jan 6, 2025
@pront pront disabled auto-merge January 6, 2025 18:54
@pront pront enabled auto-merge January 6, 2025 19:34
auto-merge was automatically disabled January 7, 2025 02:31

Head branch was pushed to by a user without write access

@titaneric
Copy link
Contributor Author

It seems that cargo vdev test-vrl does not build from the latest VRL crate. Let me study it.

@titaneric
Copy link
Contributor Author

I execute cargo update to update the vrl crate from latest commit, and the cargo vdev test-vrl do build from the latest change. I am wondering that is it possible to do the same thing in CI stage.

@pront
Copy link
Member

pront commented Jan 7, 2025

I execute cargo update to update the vrl crate from latest commit, and the cargo vdev test-vrl do build from the latest change. I am wondering that is it possible to do the same thing in CI stage.

We automated this step but it seems like we haven't been getting update PRs. Nothing to do on your side. We will take care of this PR when the VRL is updated.

Made this manually #22135

@pront pront enabled auto-merge January 7, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants