-
Notifications
You must be signed in to change notification settings - Fork 796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add initial date range to interval selection example #3667
Conversation
@dsmedia thanks for opening this PR!
I agree with these points. One question, do you think this example would make more sense in a different category?
But they are catgorised as interactive charts. There is also VL-interactive_overview_detail I know that this wasn't a change that you introduced, but I think it would further improve discoverability of this functionality |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again for the PR @dsmedia
I'm approving now, will leave open for a bit to see if anyone else wants to weigh in on the suggestions
Co-authored-by: Dan Redding <[email protected]>
Co-authored-by: Dan Redding <[email protected]>
Applied suggestions from review and activated auto-merge. Thanks @dsmedia! Much appreciated! |
This is a partial implementation of #3643, demonstrating how to set initial date ranges in interval selections through a concrete example. This improvement was made possible by the recent datetime support added in #3653 and #3662 by @dangotbanned.
Rather than creating a separate example, I opted to modify the existing interval selection example because:
Setting initial ranges is a core feature of interval selections, not a separate use case. Including it in the primary example helps users discover this capability alongside basic usage.
The change adds minimal complexity while showing the idiomatic way to set initial values using native datetime objects.
A single progressive example provides a clearer learning path than splitting this into two separate examples.
Changes made:
Remaining work in #3643: