Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bases/main_menu.py: Bump version in intro title and credits title to 0.7 #38

Merged

Conversation

stephengtuggy
Copy link
Contributor

The 0.6.2 version of vsUTCS still says 0.5.2 alpha in these two places. Oops!

Updating master to reflect version 0.7.0. We may want to update the 0.6.x branch as well.

Copy link
Member

@Loki1950 Loki1950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch @stephengtuggy

@stephengtuggy stephengtuggy merged commit d362307 into vegastrike:master Oct 31, 2020
@royfalk
Copy link
Contributor

royfalk commented Nov 1, 2020

At work, the way we avoid issues like this is by having the CICD plug in the value from the branch name. Something to consider.

@BenjamenMeyer
Copy link
Member

@royfalk its mixed. There's a few solutions methods; I haven't found a good one yet. Using branch/tag names makes it hard to use 0.6.x as the branch as x isn't valid in the numeric field, meaning we're also having to make a lot more branches.

Other solutions use environment variables, or specialized packages. Honestly I haven't seen a good one. We can certainly explore options in an Issue though.

@Loki1950
Copy link
Member

Loki1950 commented Nov 3, 2020

What about adding a check and verify step to the release routine for now so we at least don't get to embarrassed in the future.

@BenjamenMeyer
Copy link
Member

For my Python projects I usually add something to the unit tests to make sure things match up (typically b/c it's specified in multiple places)... not sure how we can do that here or if that would apply.

Opened vegastrike/Assets-Masters#19 to continue the discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants