Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use version 0.13. Update build.sbt to cross compile. #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Use version 0.13. Update build.sbt to cross compile. #13

wants to merge 1 commit into from

Conversation

danhper
Copy link

@danhper danhper commented Mar 27, 2014

Change xsbt-gpg plugin to sbt-pgp plugin as the former is not
available with the current version of sbt.

Update build.sbt to update Scala 2.9 patch version and to
cross compile with versions 2.9.2 and 2.10.3.

I did not found any incompatibility so the project should cross compile
properly.
The cross build and artifact publish should work with

sbt +compile
sbt +publish

Change xsbt-gpg plugin to sbt-pgp plugin as the former is not
available with the current version of sbt.

Update build.sbt to update Scala 2.9 patch version and to
cross compile with versions 2.9.2 and 2.10.3.
@velvia
Copy link
Owner

velvia commented Mar 27, 2014

@tuvistavie many thanks. I wonder if we shouldn't just upgrade wholesale to 2.10, after all 2.11 is almost out.

Would you mind updating the README as well so that folks know how to publish for 2.10?

@danhper
Copy link
Author

danhper commented Mar 27, 2014

@velvia Thanks for the answer. I also think that there is not really
any need to keep the 2.9 compatibility further. Would you like me
to add a commit to remove the 2.9 build?

Would you mind updating the README as well so that folks know
how to publish for 2.10?

To fetch the dependency, what is currently in the README

libraryDependencies += "com.github.velvia" %% "scala-storm" % "0.2.2"

should work just fine with either version 2.9 or 2.10.

By publish, do you mean publishing to Sonatype? I am not really sure
how it would be possible without the proper authorizations though.

In the meanwhile, as I wanted to start using it for one of my projects,
I published the updated version to my personal repository, so feel
free to give it a try before merging if you wish to. It should build
without any problem with sbt 0.13 and the following settings.

scalaVersion := "2.10.3"

libraryDependencies ++= Seq(
  "storm" % "storm" % "0.9.0.1" % "provided" exclude("junit", "junit"),
  "com.github.velvia" %% "scala-storm" % "0.2.3-SNAPSHOT",
  "net.debasishg" %% "redisclient" % "2.12"
)

resolvers ++= Seq(
  "clojars" at "http://clojars.org/repo/",
  "clojure-releases" at "http://build.clojure.org/releases",
  "tuvistavie" at "http://repo.tuvistavie.com/content/groups/public"
)

@pkallos
Copy link

pkallos commented Apr 25, 2014

👍

@velvia
Copy link
Owner

velvia commented Apr 25, 2014

@tuvistavie Go ahead and remove Scala 2.9 from the build. I'll follow up by testing against Storm 0.9.0.1 or thereabouts and republish. Thanks!

(Actually I'm tempted to publish to Bintray, which is far far easier. They have some kind of integration with Maven central.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants