Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify more robust check to detect if the response variable for continous reproduction tasks is in degrees or radians. #45

Closed
GidonFrischkorn opened this issue Feb 2, 2024 · 1 comment · Fixed by #74
Assignees
Labels
PR - minor Pull-request should update minor version
Milestone

Comments

@GidonFrischkorn
Copy link
Collaborator

We discussed that already, but I still wanted to note it done so that we keep track of this issue. Currently, we simply evaluate if any value of the response variable is larger than 10. An initial step would be to set that limit to 2*pi as this should be the maximum value you can obtain if you wrap to angles from 0 to 360 degrees from one another without using the wrap function. This would be a more principled thershold to start with.

Maybe we can build from there and then think about a more general way to test for the scaling of the response variable. This will likely be also relevant for accumulator models that will require reaction times in seconds instead of milliseconds. So, coming up with a general solution would be great.

@GidonFrischkorn GidonFrischkorn added the PR - minor Pull-request should update minor version label Feb 2, 2024
@venpopov venpopov added this to the 1.0.0 milestone Feb 2, 2024
@venpopov
Copy link
Owner

venpopov commented Feb 6, 2024

just give a warning if abs(response variable) has > 2*pi, but do not transform

add deg2rad and rad2deg functions

@GidonFrischkorn GidonFrischkorn linked a pull request Feb 8, 2024 that will close this issue
venpopov pushed a commit that referenced this issue Jan 23, 2025
…ter-transformation

43 feature request parameter transformation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR - minor Pull-request should update minor version
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants