Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data check and add deg2rad & rad2deg #74

Merged
merged 4 commits into from
Feb 8, 2024

Conversation

GidonFrischkorn
Copy link
Collaborator

Summary

Tests

[x] Confirm that all tests passed
[x] Confirm that devtools::check() produces no errors

Release notes

  • Add deg2rad & rad2deg functions
  • Only throw warning for VWM models if values larger than 2pi are detected for the response variable

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e2c1fc0) 65.84% compared to head (37cc6c0) 65.80%.
Report is 2 commits behind head on develop.

Files Patch % Lines
R/helpers-data.R 70.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop      #74      +/-   ##
===========================================
- Coverage    65.84%   65.80%   -0.04%     
===========================================
  Files           16       16              
  Lines          969      971       +2     
===========================================
+ Hits           638      639       +1     
- Misses         331      332       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Add "             The model requires the response variable to be in radians.\n" to the warning so that users don't wonder what is the problem
update test based on my addition to the warning
Copy link
Owner

@venpopov venpopov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this line to the warning:

The model requires the response variable to be in radians.\n

so that users don't wonder what to do

@venpopov venpopov merged commit 8a99014 into develop Feb 8, 2024
4 checks passed
@venpopov venpopov deleted the 45-robust-check-response-variable-for-CRT branch February 8, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants