-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/117 add a message upon loading the package #137
Merged
venpopov
merged 7 commits into
develop
from
feature/117-add-a-message-upon-loading-the-package
Feb 27, 2024
Merged
Feature/117 add a message upon loading the package #137
venpopov
merged 7 commits into
develop
from
feature/117-add-a-message-upon-loading-the-package
Feb 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/venpopov/bmm into feature/117-add-a-message-upon-loading-the-package
GidonFrischkorn
added
documentation
Improvements or additions to documentation
PR - patch
Pull request should update patch version
labels
Feb 27, 2024
perfect, will checkout now |
- bmm_options() allows to view or set all bmm global options - it is called onLoad to set defaults and display them in the package load message - add tryCatch2 to be able to handle messages and display them when desired
venpopov
approved these changes
Feb 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I added a new commit:
- new function bmm_options and use it onLoad
- bmm_options() allows to view or set all bmm global options
- it is called onLoad to set defaults and display them in the package load message
- add tryCatch2 to be able to handle messages and display them when desired
- version bump and news entry
When you load the package now it looks like this:
venpopov
assigned venpopov and GidonFrischkorn and unassigned GidonFrischkorn and venpopov
Feb 27, 2024
venpopov
deleted the
feature/117-add-a-message-upon-loading-the-package
branch
February 27, 2024 13:32
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Improvements or additions to documentation
PR - patch
Pull request should update patch version
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I just thought that I share my implementation and then you can have a look at what is there and add things if there are settings that you think we should set
.onLoad
Tests
[x] Confirm that all tests passed
[x] Confirm that devtools::check() produces no errors
Release notes