Restructure function and internal clean-up #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove bmm$fit_args - add functions for resetting formula environments to avoid storing unnecessary objects -
3 tasks
GidonFrischkorn
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mostly internal cleanup
Simplifies the structure of *$bmm and cleans up environments stored with formulas. Before we were storing the entire environment unintentionally leading to larger objects that usual.
Finish the restructure() method. Now any model fitted after version 0.2.0 can be used with all new methods. For example, the fit of Klaus to Unsworth data now works with the new summary. As we change things in the future, we should add things to the restructure function when necessary
Closes #147. Closes #148
Tests
[X] Confirm that all tests passed
[X] Confirm that devtools::check() produces no errors
Release notes