Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure fit_model and default_prior work when there are no fixed parameters #172

Merged
merged 4 commits into from
Mar 23, 2024

Conversation

venpopov
Copy link
Owner

Summary

Fixes #170

Tests

[x] Confirm that all tests passed
[x] Confirm that devtools::check() produces no errors

Release notes

@venpopov venpopov linked an issue Mar 23, 2024 that may be closed by this pull request
Copy link
Collaborator

@GidonFrischkorn GidonFrischkorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just had one comment, to add an effect prior for the mu1 parameters. Technically, users can specify effects on this parameter. So, we should add a default prior for effects too.

R/bmm_model_IMM.R Show resolved Hide resolved
@GidonFrischkorn GidonFrischkorn self-requested a review March 23, 2024 19:25
@venpopov venpopov merged commit 34941e1 into develop Mar 23, 2024
3 checks passed
@venpopov venpopov deleted the bugfix/issue-170-no-fixed-pars-condition branch March 23, 2024 19:34
@venpopov venpopov added this to the 1.0.0 milestone Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setting prior fails if there are no fixed parameters in the model
2 participants