-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/issue 163 naming consistency #177
Conversation
…bout-default_prior-standata-and-stancode
…bout-default_prior-standata-and-stancode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Phew... this was tracking a lot of find & replace details. I tested the changes and added warnings you implemented on my local testing codes and everything ran as expected. This has reduced inconsistencies throughout the package a lot, but it is likely we will still find some every now and then.
Summary
This PR changes the easier things from #163:
cores = N
where N is the number of chains to run in parallel, just like in brmsSince restructuring the models to use a version argument would require a bigger change and testing, I decided to make this into a separate PR.
Tests
[X] Confirm that all tests passed
[X] Confirm that devtools::check() produces no errors
Release notes