Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update IMM specification & Fix random generation functions #210

Merged
merged 7 commits into from
May 21, 2024

Conversation

GidonFrischkorn
Copy link
Collaborator

  • change parameterization of the IMM models to match the model in Oberauer et al. (2017)
  • make argument naming in distribution functions consistent with snake_case
  • fix bug in random generation function

Summary

Tests

[x] Confirm that all tests passed
[x] Confirm that devtools::check() produces no errors

Release notes

  • fix bug in random generation functions for specific parameter combinations in the mixture3p and the imm models
  • change parameterization of the IMM to more closely resemble the model published in Oberauer et al. (2017)

- change parameterization of the IMM models to match the model in Oberauer et al. (2017)
- make argument naming in distribution functions consistent with snake_case
- fix bug in random generation function
@GidonFrischkorn GidonFrischkorn requested a review from venpopov May 21, 2024 16:57
@GidonFrischkorn GidonFrischkorn linked an issue May 21, 2024 that may be closed by this pull request
- implement the changed parmaeterization of the imm in the density function for the IMM
@venpopov venpopov merged commit 90c961f into develop May 21, 2024
2 checks passed
@venpopov venpopov deleted the update-imm branch May 21, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Random generate functions problem with swaps
2 participants