Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update data sets #94

Merged
merged 3 commits into from
Feb 17, 2024
Merged

Update data sets #94

merged 3 commits into from
Feb 17, 2024

Conversation

GidonFrischkorn
Copy link
Collaborator

@GidonFrischkorn GidonFrischkorn commented Feb 13, 2024

Summary

  • updated the data sets to code some variables (e.g. setsize) as factors
  • removed a bug, were some responses in the ZhangLuck_2008 data set were not wrapped around the circle.

Tests

[x] Confirm that all tests passed
[x] Confirm that devtools::check() produces no errors

Release notes

I have updated the data sets to include factor codings for some variables and made sure that the dependent variables ranges from -pi to pi.
@GidonFrischkorn GidonFrischkorn marked this pull request as draft February 13, 2024 07:34
@GidonFrischkorn GidonFrischkorn self-assigned this Feb 17, 2024
@GidonFrischkorn GidonFrischkorn added this to the 1.0.0 milestone Feb 17, 2024
@GidonFrischkorn GidonFrischkorn marked this pull request as ready for review February 17, 2024 12:31
@venpopov venpopov merged commit 6a1ce67 into develop Feb 17, 2024
3 checks passed
@venpopov venpopov deleted the Update-Data-Sets branch February 17, 2024 13:37
@GidonFrischkorn
Copy link
Collaborator Author

GidonFrischkorn commented Feb 17, 2024

Looks good to me. Thanks for taking care of the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants