-
Notifications
You must be signed in to change notification settings - Fork 27.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Turbopack] Inline commonly used storages #75284
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Stats from current PRDefault BuildGeneral
Client Bundles (main, webpack)
Legacy Client Bundles (polyfills)
Client Pages
Client Build Manifests
Rendered Page Sizes
Edge SSR bundle Size
Middleware size
Next Runtimes
build cache
Diff detailsDiff for main-HASH.jsDiff too large to display |
sokra
force-pushed
the
sokra/inline-storage
branch
from
January 24, 2025 16:34
08628ad
to
34308a8
Compare
Tests Passed |
sokra
changed the title
move code from macro into generic struct
[Turbopack] Inline commonly used storages
Jan 24, 2025
mischnic
reviewed
Jan 24, 2025
self.dynamic.get_mut_or_insert_with(key, f) | ||
} | ||
|
||
pub fn iter<'l>( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the following explicit lifetimes could be elided: 'l
mischnic
approved these changes
Jan 24, 2025
sokra
force-pushed
the
sokra/box-inner-storage
branch
from
January 24, 2025 18:07
d2f3ace
to
dee5be2
Compare
sokra
force-pushed
the
sokra/inline-storage
branch
from
January 24, 2025 18:08
34308a8
to
49d01f6
Compare
sokra
changed the base branch from
sokra/box-inner-storage
to
graphite-base/75284
January 24, 2025 21:05
sokra
force-pushed
the
sokra/inline-storage
branch
from
January 24, 2025 21:05
766c1f7
to
7d053b1
Compare
sokra
force-pushed
the
graphite-base/75284
branch
from
January 24, 2025 21:05
dee5be2
to
111f334
Compare
sokra
force-pushed
the
sokra/inline-storage
branch
from
January 24, 2025 21:06
7d053b1
to
59bb18b
Compare
Merge activity
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes PACK-3818