Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid adding and committing every file when releasing #163

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Avoid adding and committing every file when releasing #163

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5d4dd34
Avoid adding and committing every file when releasing
Aug 24, 2019
418fa4a
Commit package-lock.json only if present
abarmat Dec 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/bump.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ module.exports = async (type, preSuffix) => {
createSpinner('Creating release commit');

try {
await runGitCommand(`git add -A && git commit -a -m "${version}"`);
await runGitCommand(
`git add package.json package-lock.json && git commit -m "${version}"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would fail if a package-lock.json is missing, i.e. if the user uses yarn.
You should check before if there is a package-lock.json or yarn.lock present in my opinion.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback. I've added a check to commit package-lock.json only if it is present. I excluded yarn.lock from the commit as I see release is only changing package.json and package-lock.json in the increment() function.

);
} catch (err) {
fail(err.message);
}
Expand Down