-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic Speed support #23
base: master
Are you sure you want to change the base?
Conversation
When not provided
@yoiang Are you still looking to get this merged? If so, please resolve the conflicts, which are fortunately not in a I see that speed has not been in the GPX standard since 2004, so your PR seems appropriate. Do you agree, @nkanetka? |
Sounds good, I'll fix the conflicts! |
# Conflicts: # Demo/DemoView.swift # GpxLocationManager/GpxLocationManager.swift
Should be good to merge! |
Thanks. I will review it this weekend. |
@yoiang It's getting close. Some comments. I'm not sure the speeds being displayed in meters per second are correct. This was a run I recorded, and I doubt I ever reached a speed of, for example, 262.8 m/s. That number was reported on 10X mode. I slowed down to 1X, and speeds were lower, for example 25 m/s, but that's still too high for a run. Speeds should be closer to 2.6 m/s, which is ten minutes per mile, likely the pace I averaged on this extremely hilly run. I am not a designer, but the layouts of the new labels could use some love. I would align the trailing edges of When left running long enough, the demo repeatably crashes on this line in |
@vermont42 262.80 m/s is your speed calculated at 10X. If you want the speed at 1X you can switch down. The layout is built on top of what was there already, feel free to change it however you'd like. The crash is the topic of discussion in #22 (comment) , #26, #27, should the fix be included here? |
@vermont42 Let's try to get PR #27 merged in so that we can update this PR with safe array accessing. |
GPX 1.1 no longer provides a speed field, when it is not provided calculate
speed
manually, simple point to point calculation.I haven't applied the linting and organization changes found in #22 because I assume we're going to merge that PR first. If not I can bring them to this change as well!