Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard mappers from truncated quality strings #4492

Merged
merged 6 commits into from
Jan 17, 2025
Merged

Conversation

adamnovak
Copy link
Member

Changelog Entry

To be copied to the draft changelog by merger:

  • vg giraffe, vg mpmap, and vg map will now fail early with an error when encountering a read with a quality string of the wrong length (as from a truncated FASTQ)

Description

This should protect users from weirder internal errors when FASTQs get truncated. It will print errors like:

error [vg::alignment.cpp]: Read m84039_230418_213342_s3/240455777/ccs has 20540 bases of sequence but only 18671 base quality values. Was the quality information truncated?

@adamnovak adamnovak merged commit 6554344 into master Jan 17, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant