-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mini49 to keyboards #381
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pcs3rd
commented
Feb 25, 2023
- VIAL_INSECURE is not set
- Vial layout is at keyboards/mini49/via
update vial keymap
Set bootmagic_lite key to top left
lesshonor
suggested changes
Feb 27, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, delete the STLs from this pull request. Vial-QMK is a repository for firmware, not 3D models.
lesshonor
suggested changes
Feb 27, 2023
Co-authored-by: Less/Rikki <[email protected]>
rename `LAYOUT_mini49` to `LAYOUT` Co-authored-by: Less/Rikki <[email protected]>
lesshonor
suggested changes
Mar 22, 2023
lesshonor
reviewed
Mar 24, 2023
update photo
lesshonor
approved these changes
Apr 12, 2023
DPoplin
pushed a commit
to DPoplin/vial-qmk
that referenced
this pull request
Apr 19, 2023
* Add mini49 back * Update readme.md * Update keymap.c update vial keymap * Update keymap.c * Create rules.mk * Update readme.md * Update readme.md * Update readme.md * rename vial/ to via/ * Update readme.md * Update config.h Set bootmagic_lite key to top left * Update readme.md * Update keyboards/mini49/config.h Co-authored-by: Less/Rikki <[email protected]> * Update keyboards/mini49/keymaps/vial/keymap.c rename `LAYOUT_mini49` to `LAYOUT` Co-authored-by: Less/Rikki <[email protected]> * Change code per previous suggestions * remove mini49/config.h * Tonight's last commit. * I lied. * migrate layout to info.json * Update rules.mk * Update readme.md * remove mini49.h and remove reference from info.json * Update readme.md update photo * revert pico-sdk to 07edde8 --------- Co-authored-by: Less/Rikki <[email protected]>
lesshonor
added a commit
to lesshonor/vial-qmk
that referenced
this pull request
Apr 19, 2023
* Add mini49 back * Update readme.md * Update keymap.c update vial keymap * Update keymap.c * Create rules.mk * Update readme.md * Update readme.md * Update readme.md * rename vial/ to via/ * Update readme.md * Update config.h Set bootmagic_lite key to top left * Update readme.md * Update keyboards/mini49/config.h Co-authored-by: Less/Rikki <[email protected]> * Update keyboards/mini49/keymaps/vial/keymap.c rename `LAYOUT_mini49` to `LAYOUT` Co-authored-by: Less/Rikki <[email protected]> * Change code per previous suggestions * remove mini49/config.h * Tonight's last commit. * I lied. * migrate layout to info.json * Update rules.mk * Update readme.md * remove mini49.h and remove reference from info.json * Update readme.md update photo * revert pico-sdk to 07edde8 --------- Co-authored-by: Less/Rikki <[email protected]>
lesshonor
added a commit
to lesshonor/vial-qmk
that referenced
this pull request
Jun 15, 2023
* Add mini49 back * Update readme.md * Update keymap.c update vial keymap * Update keymap.c * Create rules.mk * Update readme.md * Update readme.md * Update readme.md * rename vial/ to via/ * Update readme.md * Update config.h Set bootmagic_lite key to top left * Update readme.md * Update keyboards/mini49/config.h Co-authored-by: Less/Rikki <[email protected]> * Update keyboards/mini49/keymaps/vial/keymap.c rename `LAYOUT_mini49` to `LAYOUT` Co-authored-by: Less/Rikki <[email protected]> * Change code per previous suggestions * remove mini49/config.h * Tonight's last commit. * I lied. * migrate layout to info.json * Update rules.mk * Update readme.md * remove mini49.h and remove reference from info.json * Update readme.md update photo * revert pico-sdk to 07edde8 --------- Co-authored-by: Less/Rikki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.