-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCS-2425: Merge autogen: mlmodel, motion #3091
DOCS-2425: Merge autogen: mlmodel, motion #3091
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but there are two longer choose snippets getting lost. Can you confirm that's intended or open a ticket to add them to upstream?
|
||
For more information, see the [Python SDK Docs](https://python.viam.dev/autoapi/viam/services/motion/index.html#viam.services.motion.MotionClient.move). | ||
|
||
```python {class="line-numbers linkable-line-numbers"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a much better example I think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, another split code sample upstream: https://python.viam.dev/autoapi/viam/services/motion/client/index.html#viam.services.motion.client.MotionClient.move
I'll make a PR to fix and re-run with the fixed,staged version. 👍
destination_frame="world") | ||
``` | ||
|
||
For a more complicated example, take the same scenario and get the pose of the same gripper with respect to an object situated at a location (100, 200, 0) relative to the "world" frame: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels like it should also remain - added as a secondary example to the python docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, re-added it back 👍
@@ -0,0 +1,14 @@ | |||
<!-- preserve-formatting --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This type of override makes me very nervous. It'll be outdated so quickly. But we'll address it later
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3091 |
Merge autogen content for
mlmodel
,motion
.