Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-2564: Add Grafana to viz howto #3107

Merged

Conversation

andf-viam
Copy link
Contributor

@andf-viam andf-viam commented Jul 5, 2024

Add Grafana tab to visualize data how-to guide, and convert existing steps to be all-others in separate tab.

  • Opted for simple (how-to), so omitting example forms of various URIs and connection strings. Can re-add (from docs/tutorials/services/visualize-data-grafana.md if helpful)

NOTICED: tablestep and tabs seem to require a specific order, perhaps tabs with tablesteps within them are not permitted, but tablesteps with tabs in them is? If so I can try switching around, but more than one tablestep is specific to the grafana tab. I could see a solution where I declare the tabset in each tablestep, if there is no way to include tablesteps within tabs. Hoping I just did something wrong.

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jul 5, 2024
@npentrel
Copy link
Collaborator

npentrel commented Jul 9, 2024

Annoyingly I still see it on staging...

Copy link
Collaborator

@npentrel npentrel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % confirmation that formatting issue is gone

@viambot
Copy link
Member

viambot commented Jul 9, 2024

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3107

@andf-viam andf-viam merged commit 3863d3d into viamrobotics:main Jul 9, 2024
8 checks passed
@andf-viam
Copy link
Contributor Author

@npentrel Thanks so much for the help!

@andf-viam andf-viam deleted the DOCS-2564-add-grafana-viz-howto branch July 9, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants