DOCS-2644: Address Alyssa's feedback #3144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viambot
added
the
safe to build
JessamyT
requested changes
Jul 19, 2024
docs/use-cases/image-data.md
Outdated
| @@ -69,18 +70,37 @@ For example, set it to `0.05` to capture an image every 20 seconds. | |||
|
|
|||
| Set the MIME type to your desired image format, for example `image/jpeg`. | |||
|
|
|||
| **Click save to start capturing data.** | |||
There was a problem hiding this comment.
It's quite far down in the step, so worried people will miss it/forget
docs/use-cases/image-data.md
Outdated
| {{% /tablestep %}} | ||
| {{% tablestep %}} | ||
| {{<imgproc src="/services/ml/collect.svg" class="fill alignleft" style="max-width: 150px" declaredimensions=true alt="Train models">}} | ||
| **4. View data in the Viam app** | ||
|
|
||
| {{< alert title="Wait until data appears" color="note" >}} | ||
| Your data will sync at the specified sync interval, which may mean you have to wait for data to appear. |
There was a problem hiding this comment.
Suggested change
| Your data will sync at the specified sync interval, which may mean you have to wait for data to appear. | |
| Your data will sync at the specified sync interval, which may mean you have to wait and then refresh the page for data to appear. |
| Your data will sync at the specified sync interval, which may mean you have to wait for data to appear. | ||
|
|
||
| If no data appears after the sync interval, check the [**Logs**](/cloud/machines/#logs) and ensure that the condition for filtering is met. | ||
| You can add a [`transform` camera](/components/camera/transform/) to see detections or classifications live from the [**CONTROL** tab](/cloud/machines/#control). |
There was a problem hiding this comment.
This seems slightly unrelated to this alert. Consider moving/removing or at least adding a new line to make a separate paragraph.
There was a problem hiding this comment.
removed the alert around it
npentrel
commented
Jul 19, 2024
npentrel
commented
Jul 19, 2024
Co-authored-by: JessamyT <[email protected]>
Co-authored-by: JessamyT <[email protected]>
npentrel
commented
Jul 19, 2024
Co-authored-by: JessamyT <[email protected]>
JessamyT
reviewed
Jul 19, 2024
JessamyT
reviewed
Jul 19, 2024
docs/use-cases/image-data.md
Outdated
Comment on lines
118
to
121
| {{% /tablestep %}} | ||
| {{% tablestep link="/services/vision/"%}} | ||
| {{<imgproc src="/services/ml/train.svg" class="fill alignleft" style="max-width: 150px" declaredimensions=true alt="Train models">}} | ||
| **2. Add an ML model to your machine** |
There was a problem hiding this comment.
Suggested change
| {{% /tablestep %}} | |
| {{% tablestep link="/services/vision/"%}} | |
| {{<imgproc src="/services/ml/train.svg" class="fill alignleft" style="max-width: 150px" declaredimensions=true alt="Train models">}} | |
| **2. Add an ML model to your machine** |
This is duplicated, and then step numbers need changing.
Co-authored-by: JessamyT <[email protected]>
JessamyT
approved these changes
Jul 19, 2024
|
You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3144 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.