Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS-3311: Update Python module test and upload steps #3890

Merged
merged 9 commits into from
Jan 31, 2025

Conversation

JessamyT
Copy link
Collaborator

@JessamyT JessamyT commented Jan 22, 2025

@viambot viambot added the safe to build This pull request is marked safe to build from a trusted zone label Jan 22, 2025
Copy link

netlify bot commented Jan 22, 2025

Deploy Preview for viam-docs ready!

Name Link
🔨 Latest commit 3144015
🔍 Latest deploy log https://app.netlify.com/sites/viam-docs/deploys/679d5f4faad5b800087caa0f
😎 Deploy Preview https://deploy-preview-3890--viam-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 20 (🔴 down 19 from production)
Accessibility: 98 (no change from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: 70 (no change from production)
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@JessamyT JessamyT marked this pull request as draft January 22, 2025 02:03
@viambot
Copy link
Member

viambot commented Jan 22, 2025

You can view a rendered version of the docs from this PR at https://docs-test.viam.dev/3890

@JessamyT JessamyT marked this pull request as ready for review January 29, 2025 18:01
@JessamyT JessamyT marked this pull request as draft January 29, 2025 18:02
@JessamyT JessamyT marked this pull request as ready for review January 29, 2025 19:07
Copy link
Member

@michaellee1019 michaellee1019 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked through the preview environment, all looks good to be except I think the tab name is confusing.

docs/operate/get-started/other-hardware/_index.md Outdated Show resolved Hide resolved
"entrypoint": "reload.sh",
"first_run": "",
"build": {
"build": "rm -f module.tar.gz && tar czf module.tar.gz requirements.txt src/*.py meta.json setup.sh reload.sh",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine for now, don't change anything. Im my updates for the generator to use hotreloading by default, I will probably create a makefile or sh script. Will let you know how that goes

docs/operate/get-started/other-hardware/_index.md Outdated Show resolved Hide resolved
@JessamyT JessamyT merged commit 38e62e0 into viamrobotics:main Jan 31, 2025
12 checks passed
@JessamyT JessamyT deleted the 3311pkgup branch January 31, 2025 23:45
Copy link

🔎💬 Inkeep AI search and chat service is syncing content for source 'Viam Docs (https://docs.viam.com)'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to build This pull request is marked safe to build from a trusted zone
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants