[RSDK-9677] add GetModelsFromModules to robot interface #4676
Conversation
viambot
added
the
safe to test
robot/impl/local_robot.go
Outdated
| @@ -1065,6 +1065,24 @@ func (r *localRobot) discoverRobotInternals(query resource.DiscoveryQuery) (inte | |||
| } | |||
| } | |||
|
|
|||
| func (r *localRobot) GetModelsFromModules(ctx context.Context) ([]*resource.ModuleModelDiscovery, error) { | |||
There was a problem hiding this comment.
@cheukt @zaporter-work wasn't sure whether everything should live at the robot level or if I should add something to the module manager to better surface these messages.
Also not sure who I should be having to review this stuff, I assumed it would be cheuk but if theres a more appropriate person lmk
There was a problem hiding this comment.
I think having more of the logic in the modmanager would make a bit more sense and make it easier to test. I can review but I didn't implement the original code nor am I the end consumer, would be good to have @zaporter-work as a reviewer too
There was a problem hiding this comment.
kk moved to module manager. Just need to add tests for the server & manager and it should be ready
JohnN193
changed the title
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
viambot
added
safe to test
Initial implementation of GetModelsFromModules in Go. Currently working on the discovery service in a separate branch to make it easier on reviewers.
Still needs tests but I think its implemented everywhere else?
ticket: https://viam.atlassian.net/browse/RSDK-9677