RSDK-9549: Make RpcSubtype model api ResourceRPCSubtype #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuqdog
approved these changes
Jan 8, 2025
src/viam/sdk/module/handler_map.hpp
Outdated
|
|
||
| class HandlerMap; | ||
|
|
||
| } |
There was a problem hiding this comment.
(nit) should have // namespace v1 at the end?
There was a problem hiding this comment.
grr yes clang-format loves to not put them in
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the implementation of an SDK type to more closely model its corresponding API type. Note that handler_map.cpp contains what is more or less the to_proto and from_proto of RPCSubtype, so we remove the ServiceDescriptor member.
The comparison operators in this and some other classes have been optimized to not construct a concatenated string every time they're called
Also includes some drive-by changes for domino-effect missing includes, minor cleanups, etc
Per @stuqdog we're not sure why RPCSubtype originally had a ServiceDescriptor member--it seems its only use was in using the DebugString to implement
operator<to make RPCSubtype usable as amapkey. I'm not sure what tests if any will exercise that this is still behaving as expected or if we know why this might have been implemented that way in the first place, cc @acmorrow for any ideas or sugestions