Don't run unit tests by default

victronenergy · Jul 26, 2024 · 4cb75fd · 4cb75fd
1 parent 8fec334
commit 4cb75fd
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/build-wasm.yml b/.github/workflows/build-wasm.yml
@@ -101,7 +101,7 @@ jobs:
         export QTDIR=/opt/hostedtoolcache/Qt/$QT_VERSION/wasm_singlethread
         export PATH=$PATH:/opt/hostedtoolcache/Qt/Tools/CMake/bin
         mkdir build-wasm && cd build-wasm
-        ${QTDIR}/bin/qt-cmake -DCMAKE_BUILD_TYPE=MinSizeRel ..
+        ${QTDIR}/bin/qt-cmake -DCMAKE_BUILD_TYPE=MinSizeRel -DRUN_UNIT_TESTS=ON ..
         cmake --build .
         cd -
     - name: Patch and pack webassembly files

diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -58,7 +58,7 @@ else()
 endif()
 
 option(LOAD_QML_FROM_FILESYSTEM "disable filesystem loading via cmake -DLOAD_QML_FROM_FILESYSTEM=OFF" ON) # Enabled by default
-option(RUN_UNIT_TESTS "only affects desktop builds. Disable via cmake -DRUN_UNIT_TESTS=OFF" ON) # Enabled by default
+option(RUN_UNIT_TESTS "only affects desktop builds. Enable via cmake -DRUN_UNIT_TESTS=ON" OFF) # Disabled by default
 
 if (${CMAKE_SYSTEM_PROCESSOR} STREQUAL ${CMAKE_HOST_SYSTEM_PROCESSOR})
     set(VENUS_DESKTOP_BUILD ON)

diff --git a/tests/units/tst_units.qml b/tests/units/tst_units.qml
@@ -85,7 +85,7 @@ TestCase {
 					expect(unit, 123456789012345, "123", "T" + unitString)
 				}
 			} else {
-				expect(unit, 1234, "1234", unitString)
+				expect(unit, 123, "1234", unitString)
 				expect(unit, 12345, "12345", unitString)
 				expect(unit, 123456789, "123456789", unitString)
 			}