Generator Control cards should not be displayed when startStop1 disabled

Fixes #1239
victronenergy · Jan 6, 2025 · b62d33d · b62d33d
1 parent 89b184a
commit b62d33d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 0 deletions.
diff --git a/data/common/Generator.qml b/data/common/Generator.qml
@@ -14,6 +14,7 @@ Device {
 	readonly property int manualStartTimer: _manualStartTimer.isValid ? _manualStartTimer.value : 0
 	readonly property int runtime: _runtime.value || 0
 	readonly property int runningBy: _runningBy.isValid ? _runningBy.value : 0
+	readonly property bool startstop1Enabled: _startstop1Enabled.value === 1
 
 	readonly property string runningByText: Global.generators.runningByText(runningBy)
 	readonly property string stateText: Global.generators.stateText(state)
@@ -56,6 +57,10 @@ Device {
 		uid: serviceUid + "/AutoStartEnabled"
 	}
 
+	readonly property VeQuickItem _startstop1Enabled: VeQuickItem {
+		uid: serviceUid + "/startstop1/Enabled"
+	}
+
 	function start(durationSecs) {
 		_manualStartTimer.setValue(durationSecs)
 		_manualStart.setValue(1)

diff --git a/pages/controlcards/GeneratorCard.qml b/pages/controlcards/GeneratorCard.qml
@@ -16,6 +16,7 @@ ControlCard {
 	title.text: CommonWords.generator
 	status.text: root.generator.stateText
 	status.rightPadding: timerDisplay.width + Theme.geometry_controlCard_contentMargins
+	visible: root.generator.startstop1Enabled
 
 	GeneratorIconLabel {
 		id: timerDisplay