Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more meaningful names for Victron tank sensors #1276

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Use more meaningful names for Victron tank sensors #1276

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions data/common/Tank.qml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,12 @@ Device {
}
}

name: productId === 0xA160
// This must be a generic Victron tank sensor, where the product name is always "Tank
// sensor" and there is no custom name, so use the tank type to provide a meaningful name.
? Gauges.tankProperties(type).name
: productName || customName

description: {
if (customName.length > 0) {
return customName
Expand Down