Fix rendering issue on WASM with AsymmetricRoundedRectangle #1292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blammit
approved these changes
Jul 3, 2024
|
This fixes the line, but now the tab fade in / out looks funny. Main branch isn't perfect wrt tab fade in & out, but these changes make it a bit worse |
In WASM, AsymmetricRoundedRectangle (used in TabBar for example on the Levels page) sometimes shows a line on the edge of the clip item (between the rounded background and the non-rounded background section). The issue doesn't reproduce on desktop or on device, but it can be resolved by overlapping the rounded background section on top of the normal background section by 1 pixel (can do this now, since colours are opaque).
chriadam
force-pushed
the
chriadam/tabbar-pixel-clipping
branch
from
deeab0b to
f331d0c
Compare
|
Thanks, fixed, now use a layer to ensure the clip can't mess with the z order etc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In WASM, AsymmetricRoundedRectangle (used in TabBar for example on the Levels page) sometimes shows a line on the edge of the clip item (between the rounded background and the non-rounded background section). The issue doesn't reproduce on desktop or on device, but it can be resolved by overlapping the rounded background section on top of the normal background section by 1 pixel (can do this now, since colours are opaque).