Fix PV inverter error display and clean up product IDs #1320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same error text that is shown when clicking on a PV Inverter from the Device List. Fixes #1303
DanielMcInnes
approved these changes
Jul 12, 2024
src/productinfo.h
Outdated
| class ProductInfo : public QObject | ||
| { | ||
| Q_OBJECT | ||
| QML_NAMED_ELEMENT(ProductInfo) |
There was a problem hiding this comment.
why not just QML_ELEMENT?
There was a problem hiding this comment.
Oh true, the QML_NAMED_ELEMENT wasn't necessary. Fixed.
src/productinfo.h
Outdated
| ~ProductInfo() override {} | ||
|
|
||
| enum ProductId_Alternator { | ||
| ProductId_Wakespeed = 0xB080, // VE_PROD_ID_WAKESPEED_WS500 |
There was a problem hiding this comment.
Maybe prefix the enum entry with the enum title, eg. ProductId_Alternator_Wakespeed ?
There was a problem hiding this comment.
Done, some of the others didn't have a clear grouping, so I added Product_Misc and put those enums there.
src/productinfo.h
Outdated
| Q_ENUM(ProductId_Genset) | ||
|
|
||
| Q_INVOKABLE bool isGensetProduct(int productId) { | ||
| static const QVector<int> productIds = { |
There was a problem hiding this comment.
maybe a switch/case instead of a QVector with static lifetime?
There was a problem hiding this comment.
Yes, much nicer. Fixed, thanks.
blammit
force-pushed
the
blam/pv-inverter-error
branch
2 times, most recently
from
092ee25 to
1fe2bb4
Compare
blammit
force-pushed
the
blam/pv-inverter-error
branch
from
1fe2bb4 to
09a1485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.