Solar history fixes #1331
Merged
Solar history fixes #1331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Theme.color_dimBlue doesn't exist, so use Theme.color_lightBlue, which is the 'pressed' color for buttons.
- SolarChargers.qml: formatTrackerName() was trying to substitute a string arg that did not exist - SolarChargerPage.qml: the QuantityTable needs to ensure the tracker name is not displayed as an empty string. If the tracker name is empty, use Global.solarChargers.formatTrackerName() to find an appropriate name based on the tracker's charger.
blammit
force-pushed
the
blam/solar-history-fixes
branch
from
b7c7f3f to
5402a40
Compare
|
Can be tested in mock mode: some trackers have names, and some do not. See this example from the solar overview drilldown:
|
DanielMcInnes
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.