Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTT: refactor the producer as a finite state machine #1392

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

chriadam
Copy link
Contributor

@chriadam chriadam commented Aug 5, 2024

Contributes to issue #1385

@chriadam
Copy link
Contributor Author

chriadam commented Aug 5, 2024

I'm hoping that this one fixed #1298 also.

@chriadam chriadam force-pushed the chriadam/mqtt-state-machine branch from 4ec0cd8 to 9954286 Compare August 5, 2024 10:36
@DanielMcInnes
Copy link
Contributor

DanielMcInnes commented Aug 6, 2024

This doesn't fix #1298, it gets stuck on the screen shown below. The changes lgtm

image

@chriadam chriadam force-pushed the chriadam/mqtt-state-machine branch 6 times, most recently from f026653 to 8306c45 Compare August 6, 2024 08:36
@chriadam
Copy link
Contributor Author

chriadam commented Aug 6, 2024

Updated. Now it also fixes #1298 as per Daniel's updated testing.

@DanielMcInnes
Copy link
Contributor

DanielMcInnes commented Aug 7, 2024

Compiler warning:

/home/dmcinnes/git/victron/gui-v2/src/veutil/src/qt/ve_qitems_mqtt.cpp: In member function ‘bool VeQItemMqttProducer::isValidStateTransition(VeQItemMqttProducer::ConnectionState, VeQItemMqttProducer::ConnectionState) const’:
/home/dmcinnes/git/victron/gui-v2/src/veutil/src/qt/ve_qitems_mqtt.cpp:217:1: warning: control reaches end of non-void function [-Wreturn-type]
  217 | }

@chriadam chriadam force-pushed the chriadam/mqtt-state-machine branch from 8306c45 to 2bd7d4c Compare August 8, 2024 02:19
@chriadam
Copy link
Contributor Author

chriadam commented Aug 8, 2024

Thanks, fixed.

@chriadam chriadam force-pushed the chriadam/mqtt-state-machine branch from 2bd7d4c to 6c24243 Compare August 8, 2024 03:25
@chriadam chriadam merged commit f08c332 into main Aug 8, 2024
1 of 2 checks passed
@chriadam chriadam deleted the chriadam/mqtt-state-machine branch August 8, 2024 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants