Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customization checks and links page #1826

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mr-manuel
Copy link
Collaborator

@mr-manuel mr-manuel commented Jan 9, 2025

This could already be checked. Can be merged, after integration in venus-platform was merged.

@mr-manuel mr-manuel requested a review from blammit January 9, 2025 22:14
@mr-manuel mr-manuel force-pushed the mr-manuel/support-and-troubleshooting branch 2 times, most recently from 6c4f779 to 903f5a7 Compare January 9, 2025 22:31
Copy link
Contributor

@blammit blammit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you wait for #1815 to be merged and then work this into the new settings list structure?

@mr-manuel mr-manuel force-pushed the mr-manuel/support-and-troubleshooting branch 4 times, most recently from 1f1ed1b to 4bfb361 Compare January 14, 2025 12:48
@mr-manuel mr-manuel requested a review from blammit January 14, 2025 13:01
}
}

ListButton {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks almost the same as the reboot button in PageSettingsGeneral. Can you move that into a new component like components/listitems/ListRebootButton.qml and just customize it as needed here?

//% "HQ serial number"
text: qsTrId("pagesettingscustomizationchecks_hq_serial_number")
secondaryText: hqSerialNumberItem.value
allowed: defaultAllowed && hqSerialNumberItem.value != ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note, allowed has been renamed to preferredVisible: #1844

Also there is a PR underway that means you will want to use VisibleItemModel instead of ObjectModel: #1845

@mr-manuel mr-manuel force-pushed the mr-manuel/support-and-troubleshooting branch from 4bfb361 to 082379c Compare January 15, 2025 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants