-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customization checks and links page #1826
base: main
Are you sure you want to change the base?
Conversation
6c4f779
to
903f5a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you wait for #1815 to be merged and then work this into the new settings list structure?
1f1ed1b
to
4bfb361
Compare
} | ||
} | ||
|
||
ListButton { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks almost the same as the reboot button in PageSettingsGeneral. Can you move that into a new component like components/listitems/ListRebootButton.qml
and just customize it as needed here?
//% "HQ serial number" | ||
text: qsTrId("pagesettingscustomizationchecks_hq_serial_number") | ||
secondaryText: hqSerialNumberItem.value | ||
allowed: defaultAllowed && hqSerialNumberItem.value != "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4bfb361
to
082379c
Compare
This could already be checked. Can be merged, after integration in venus-platform was merged.