Fix Maximum ESS Grid Feed-in could be set to -1 #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As per Gui-v1, the maxFeedInPower ListSpinBox 'from' property should be set to 0. Fixes #1828
MikeTrahearn-Qinetic
force-pushed
the
miketrahearn/1828-fix-negative-grid-feed-in-value
branch
from
f1e3933 to
46e3cde
Compare
blammit
approved these changes
Jan 16, 2025
No because that's not what the fix is. We are not setting this to -1. We are preventing it from being set to -1. |
MikeTrahearn-Qinetic
deleted the
miketrahearn/1828-fix-negative-grid-feed-in-value
branch
Sorry, I meant to say, "Set maximum ESS Grid Feed-in to 0". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per Gui-v1, the maxFeedInPower ListSpinBox 'from' property should be set to 0.
Fixes #1828