Fix "Limit system feed-in" checked status and on/off behavior #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checked binding and onClicked handler must refer to the raw maxFeedInPower.dataItem.value rather than maxFeedInPower.value, since the latter may be modified by the min/max bounds. Fixes #1877
blammit
requested review from
chriadam,
DanielMcInnes and
MikeTrahearn-Qinetic
DanielMcInnes
approved these changes
Jan 24, 2025
MikeTrahearn-Qinetic
approved these changes
Jan 24, 2025
DanielMcInnes
approved these changes
Jan 24, 2025
blammit
deleted the
blam/1877-cant-uncheck-ess-limit-system-feed-in-option
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checked binding and onClicked handler must refer to the raw maxFeedInPower.dataItem.value rather than maxFeedInPower.value, since the latter may be modified by the min/max bounds.
Fixes #1877