avoids skipping validation checks for numberOfShards setting when buil… #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ding IndexMetadata With split changes, we've added SplitShardsMetadata. This object is instantiated in IndexMetadata.Builder' flow using the numberOfShards. We were invoking numberOfShards() which skips the validation check for the INDEX_NUMBER_OF_SHARDS_SETTING setting as it directly fetches the setting via `settings.getAsInt()`. Changing this to fetch this setting via INDEX_NUMBER_OF_SHARDS_SETTING.get(settings) so that validations work correctly. Signed-off-by: Paras Jain <[email protected]>
vikasvb90
approved these changes
Feb 5, 2025
vikasvb90
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ding IndexMetadata
With split changes, we've added SplitShardsMetadata. This object is instantiated in IndexMetadata.Builder' flow using the numberOfShards. We were invoking numberOfShards() which skips the validation check for the INDEX_NUMBER_OF_SHARDS_SETTING setting as it directly fetches the setting via
settings.getAsInt().Changing this to fetch this setting via INDEX_NUMBER_OF_SHARDS_SETTING.get(settings) so that validations work correctly.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.