Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI/add spell checker #1971

Closed
wants to merge 0 commits into from
Closed

Conversation

IanWorley
Copy link

@brillout
Copy link
Member

The reason I was mentioning using their npm package is because it would allow us to correct spelling mistakes by simply running an npm script.

That's what we're doing with formatting:

  • pnpm run format:check => throws an error if formatting is incorrect, used by the CI
  • pnpm run format => fixes formatting issues, used by the user

I wonder if we can reproduce the same workflow for spelling?

@IanWorley
Copy link
Author

@brillout my bad I will use the npm package

@brillout
Copy link
Member

@IanWorley 👍 Btw. how big is their npm package? It's fine if it's a bit heavy, but it shouldn't be too heavy.

@IanWorley IanWorley closed this Nov 20, 2024
@IanWorley IanWorley force-pushed the ci/add-spell-checker branch from e1f983e to a6161ab Compare November 20, 2024 21:10
@IanWorley IanWorley deleted the ci/add-spell-checker branch November 22, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants