Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Ability to check/uncheck optional dependencies at once #360

Merged
merged 4 commits into from
May 25, 2024

Conversation

PrivateN00b
Copy link
Contributor

@PrivateN00b PrivateN00b commented May 4, 2024

This PR adds a setting for situations where packages may have optional dependencies but you don't intend to see all these dependencies be checked on. The default value remains true.

Related issue: #346

Please inform me if I misunderstood the request in some way.

EDIT: I don't know either of the localized languages besides English, and most likely an AI-translated one would sound a bit weird.

@vinifmor
Copy link
Owner

Hi @NoobKozlegeny . Just tested your changes and they are fine (thank you). The only point I believe should be changed is the new property name (suggest_optdep_download) that refers to "downloading" and not the actual behavior (that is auto-selecting all optional dependencies). Perhaps, something like suggest_optdep_select ? (just a suggestion)

@PrivateN00b
Copy link
Contributor Author

Thank you for the reply! Yeah, that could be arranged, but I will be a bit occupied until Wednesday, so don't merge this PR yet.

@PrivateN00b
Copy link
Contributor Author

Hi @NoobKozlegeny . Just tested your changes and they are fine (thank you). The only point I believe should be changed is the new property name (suggest_optdep_download) that refers to "downloading" and not the actual behavior (that is auto-selecting all optional dependencies). Perhaps, something like suggest_optdep_select ? (just a suggestion)

@vinifmor Rename done :3

@vinifmor vinifmor merged commit 4cd1172 into vinifmor:master May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants