Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New landing page design #187

Closed

Conversation

shreoshi-roy
Copy link

@shreoshi-roy shreoshi-roy commented Mar 18, 2020

Description

Added a new landing page design created using Paint and Photoshop.
This is my first issue so please guide me if something is wrong.
Please consider it in an issue of medium or high difficulty as I have used Photoshop for the design.

Fixes # Issue #176 (Please consider if it can serve as a solution for issue #170 or #173 if posssible)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Reviewer: Vinit Shahdeo

@auto-assign auto-assign bot requested a review from vinitshahdeo March 18, 2020 00:11
@welcome
Copy link

welcome bot commented Mar 18, 2020

Thanks for opening this pull request!
Please add @vinitshahdeo as a reviewer if you haven't added.

@shreoshi-roy shreoshi-roy changed the base branch from master to feature/frontend March 18, 2020 02:35
@amaaniqbal
Copy link

Nice start! But as you might have read, I mentioned in the issue, not to include any tank divs here. Please remove them from the design. And try to incorporate some other components in the design.

If you wish to work with paint/photoshop, please comment on the respective issue and remove your comment from #176, I will unassign you so that someone else can take it up.

@amaaniqbal
Copy link

Also, keep your work inside screenshots/ directory within a folder named Instance #{number}.

@shreoshi-roy
Copy link
Author

shreoshi-roy commented Mar 18, 2020 via email

@amaaniqbal
Copy link

It may contain a form. Water levels should only be shown to the admins, so they will not appear on the landing page.

Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me for the page after login. @amaaniqbal please review. @shreoshi-roy read the issue carefully, this is good but can't be the landing page.

@amaaniqbal
Copy link

@PragatiVerma18 I guess she is still working on it. Let her come up with something innovative.

@shreoshi-roy shreoshi-roy deleted the firstbranch branch March 21, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants