-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New landing page design #187
New landing page design #187
Conversation
Thanks for opening this pull request! |
Nice start! But as you might have read, I mentioned in the issue, not to include any tank divs here. Please remove them from the design. And try to incorporate some other components in the design. If you wish to work with paint/photoshop, please comment on the respective issue and remove your comment from #176, I will unassign you so that someone else can take it up. |
Also, keep your work inside |
Got it! Can you give me an idea of what all components you're looking to be
added on the landing page?
Should it show the water level in the tanks? Should it contain forms (as I
saw in the definition of a landing page) ?
…On Wed 18 Mar, 2020, 11:04 AM Amaan Iqbal, ***@***.***> wrote:
Also, keep your work inside screenshots/ directory within a folder named
Instance #{number}.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#187 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ANM444K6AX2MAOGTONSDKIDRIBMP7ANCNFSM4LN7YOFQ>
.
|
It may contain a form. Water levels should only be shown to the admins, so they will not appear on the landing page. |
0b62f8c
to
5c09d2f
Compare
I've update the version from 0.1.0 to 0.0.1
update package.json of react code base
Added necessary space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me for the page after login. @amaaniqbal please review. @shreoshi-roy read the issue carefully, this is good but can't be the landing page.
@PragatiVerma18 I guess she is still working on it. Let her come up with something innovative. |
…o#201) Add animated landing page design (Instance vinitshahdeo#8)
This reverts commit 4ec5b97.
This reverts commit 4ec5b97.
Description
Added a new landing page design created using Paint and Photoshop.
This is my first issue so please guide me if something is wrong.
Please consider it in an issue of medium or high difficulty as I have used Photoshop for the design.
Fixes # Issue #176 (Please consider if it can serve as a solution for issue #170 or #173 if posssible)
Type of change
Checklist:
Reviewer: Vinit Shahdeo