Skip to content

Commit

Permalink
Fix failing spec by upgrading capybara to 2.5,
Browse files Browse the repository at this point in the history
add development dependency capybara-screenshot,
replace deprecated SingleSpaceBeforeFirstArg with SpaceBeforeFirstArg for hound
  • Loading branch information
Priyank Gupta committed Feb 26, 2016
1 parent 0c0edf2 commit 4d0150c
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .hound.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Documentation:
Enabled: false

# Neatly aligned code is too swell.
SingleSpaceBeforeFirstArg:
SpaceBeforeFirstArg:
Enabled: false

# Don't mess with RSpec DSL.
Expand Down
3 changes: 3 additions & 0 deletions spec/support/capybara.rb
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
require 'capybara/rspec'
require 'capybara/rails'
require 'capybara/poltergeist'
require 'capybara-screenshot/rspec'

RSpec.configure do |config|
Capybara.javascript_driver = :poltergeist

Capybara.save_and_open_page_path = ENV['CIRCLE_ARTIFACTS'] if ENV['CIRCLE_ARTIFACTS']

Capybara.register_driver(:poltergeist) do |app|
Capybara::Poltergeist::Driver.new app, js_errors: true, timeout: 30
end
Expand Down
3 changes: 2 additions & 1 deletion spree_related_products.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ Gem::Specification.new do |s|
s.add_development_dependency 'ffaker'
s.add_development_dependency 'rspec-rails', '~> 3.1.0'
s.add_development_dependency 'sqlite3', '~> 1.3.10'
s.add_development_dependency 'capybara', '~> 2.4.4'
s.add_development_dependency 'capybara', '~> 2.5'
s.add_development_dependency 'capybara-screenshot', '~> 1.0.11'
s.add_development_dependency 'poltergeist', '~> 1.5.0'
s.add_development_dependency 'shoulda-matchers', '~> 2.5'
s.add_development_dependency 'simplecov', '~> 0.9.0'
Expand Down

0 comments on commit 4d0150c

Please sign in to comment.