Use PaymentId from common and simplify extrinsics API #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbulgarini
reviewed
Feb 13, 2024
pallets/payments/src/lib.rs
Outdated
| use PaymentState::*; | ||
| let beneficiary = ensure_signed(origin)?; | ||
| let sender = T::Lookup::lookup(sender)?; | ||
| let (sender, b) = PaymentParties::<T>::get(&payment_id)?; | ||
| ensure!(beneficiary == b, Error::<T>::InvalidPayment); |
There was a problem hiding this comment.
Maybe the error would say something more descriptive as invalid beneficiary?
olanod
force-pushed
the
updated-payment-id
branch
from
fadf299 to
b94ee4c
Compare
|
Made some changes based on review, added the manual encoding/decoding of payment id as u64 and tested the happy path manually(rococo-local zombienet) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.