[Communities] Benchmarking and Runtime Parameters #340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandres95
force-pushed
the
pallet-communities-voting
branch
from
32a1fc2 to
ff01a3a
Compare
pandres95
force-pushed
the
pallet-communities-benchmarking-runtime-parameters
branch
2 times, most recently
from
cca96ff to
607cb61
Compare
pandres95
force-pushed
the
pallet-communities-benchmarking-runtime-parameters
branch
from
b61b0e4 to
590da33
Compare
pandres95
force-pushed
the
pallet-communities-voting
branch
from
ff01a3a to
27e8965
Compare
pandres95
force-pushed
the
pallet-communities-benchmarking-runtime-parameters
branch
2 times, most recently
from
8c8f7f7 to
41b3b7c
Compare
pandres95
force-pushed
the
pallet-communities-voting
branch
2 times, most recently
from
f923d1d to
5ff9728
Compare
pandres95
force-pushed
the
pallet-communities-benchmarking-runtime-parameters
branch
from
41b3b7c to
7e62aa0
Compare
pandres95
force-pushed
the
pallet-communities-voting
branch
3 times, most recently
from
1ea36de to
8d1c47c
Compare
pandres95
force-pushed
the
pallet-communities-benchmarking-runtime-parameters
branch
from
7e62aa0 to
c811231
Compare
pandres95
force-pushed
the
pallet-communities-benchmarking-runtime-parameters
branch
from
c811231 to
6862f46
Compare
…memberships and subsequent testings
- configure benchmark helper for pallet-referenda-tracks - fix: missing imports for vec-like structures on benchmarking
…er, promote_member, and demote_member (#343) * change(runtime/kreivo): include pallet-communities on dependencies * chore(cargo): update Cargo.lock * feat(pallet-communities): implement structures and storage for governance * feat(pallet-communities): add set_decision_method extrinsic * feat(pallet-communities): implement vote extrinsic * chore(pallet-communities): add initial set of tests for governance section * fix(pallet-communities): lint * chore(cargo): update lockfile * fix(pallet-communities:tests): typo * feat(pallet-communities): better handle type bounds for T::Assets and T::Polls * chore(pallet-communities): refine usage of type aliases * change(pallet-communities:tests): support including multiple communities * feat(pallet-communities): implement unlock call * feat(pallet-communities:tests): extend dynamic communities creation on TestEnvBuilder to create tracks * chore(pallet-communities): test when casting vote on an invalid track / test tie-breaking * fix(pallet-communities): lint * chore(pallet-communities): coverage testing for AssetBalance and NativeBalance voting methods * chore(pallet-communities): add tests for unlock * feat(pallet-communities): implement remove_vote * feat(pallet-communities): implement voting for DecisionMethod::Rank * fix(pallet-communities): lint * chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * chore(cargo): update lockfile * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member * fix(kreivo-runtime): lint --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]>
pandres95
force-pushed
the
pallet-communities-benchmarking-runtime-parameters
branch
from
6862f46 to
6a0b875
Compare
olanod
requested changes
Mar 14, 2024
…in for CommunityMemberMgmt - Create and implement EnsureCommunityAccountId. - Add a benchmarking method to it. - Setup parameter for mock. - Setup parameter for runtime.
pandres95
force-pushed
the
pallet-communities-benchmarking-runtime-parameters
branch
from
2ff10f2 to
a75705e
Compare
- This is because it's not being used initially
olanod
approved these changes
Mar 15, 2024
pandres95
added a commit
that referenced
this pull request
Mar 17, 2024
* chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * change(pallet-communities): prepare - configure benchmark helper for pallet-referenda-tracks - fix: missing imports for vec-like structures on benchmarking * change(kreivo-runtime): setup benchmark helper for community tracks pallet * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member (#343) * change(runtime/kreivo): include pallet-communities on dependencies * chore(cargo): update Cargo.lock * feat(pallet-communities): implement structures and storage for governance * feat(pallet-communities): add set_decision_method extrinsic * feat(pallet-communities): implement vote extrinsic * chore(pallet-communities): add initial set of tests for governance section * fix(pallet-communities): lint * chore(cargo): update lockfile * fix(pallet-communities:tests): typo * feat(pallet-communities): better handle type bounds for T::Assets and T::Polls * chore(pallet-communities): refine usage of type aliases * change(pallet-communities:tests): support including multiple communities * feat(pallet-communities): implement unlock call * feat(pallet-communities:tests): extend dynamic communities creation on TestEnvBuilder to create tracks * chore(pallet-communities): test when casting vote on an invalid track / test tie-breaking * fix(pallet-communities): lint * chore(pallet-communities): coverage testing for AssetBalance and NativeBalance voting methods * chore(pallet-communities): add tests for unlock * feat(pallet-communities): implement remove_vote * feat(pallet-communities): implement voting for DecisionMethod::Rank * fix(pallet-communities): lint * chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * chore(cargo): update lockfile * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member * fix(kreivo-runtime): lint --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmark method for unlock * feat(kreivo-runtime): configure benchmark helper for pallet-communities * change(pallet-communities): ensure benchmarks run with default externalities * chore(cargo): update dependencies * fix(kreivo-runtime): set MembershipCollectionId to 0 * fix(pallet-commujnities): remove mock out of tests module * fix(zombienet): add parachain inclusion to relay genesis * feat(pallet-communities): receive community accountId as a valid origin for CommunityMemberMgmt - Create and implement EnsureCommunityAccountId. - Add a benchmarking method to it. - Setup parameter for mock. - Setup parameter for runtime. * change(kreivo-runtime): setup communities-related origins * change(kreivo-runtime): remove Nfts pallet from runtime - This is because it's not being used initially * fix(kreivo-runtime): add EnsureRootWithSuccess for SubmitOrigin on CommunityReferenda --------- Co-authored-by: Juan Pablo Gutiérrez Restrepo <[email protected]>
pandres95
added a commit
that referenced
this pull request
Mar 21, 2024
* chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * change(pallet-communities): prepare - configure benchmark helper for pallet-referenda-tracks - fix: missing imports for vec-like structures on benchmarking * change(kreivo-runtime): setup benchmark helper for community tracks pallet * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member (#343) * change(runtime/kreivo): include pallet-communities on dependencies * chore(cargo): update Cargo.lock * feat(pallet-communities): implement structures and storage for governance * feat(pallet-communities): add set_decision_method extrinsic * feat(pallet-communities): implement vote extrinsic * chore(pallet-communities): add initial set of tests for governance section * fix(pallet-communities): lint * chore(cargo): update lockfile * fix(pallet-communities:tests): typo * feat(pallet-communities): better handle type bounds for T::Assets and T::Polls * chore(pallet-communities): refine usage of type aliases * change(pallet-communities:tests): support including multiple communities * feat(pallet-communities): implement unlock call * feat(pallet-communities:tests): extend dynamic communities creation on TestEnvBuilder to create tracks * chore(pallet-communities): test when casting vote on an invalid track / test tie-breaking * fix(pallet-communities): lint * chore(pallet-communities): coverage testing for AssetBalance and NativeBalance voting methods * chore(pallet-communities): add tests for unlock * feat(pallet-communities): implement remove_vote * feat(pallet-communities): implement voting for DecisionMethod::Rank * fix(pallet-communities): lint * chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * chore(cargo): update lockfile * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member * fix(kreivo-runtime): lint --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmark method for unlock * feat(kreivo-runtime): configure benchmark helper for pallet-communities * change(pallet-communities): ensure benchmarks run with default externalities * chore(cargo): update dependencies * fix(kreivo-runtime): set MembershipCollectionId to 0 * fix(pallet-commujnities): remove mock out of tests module * fix(zombienet): add parachain inclusion to relay genesis * feat(pallet-communities): receive community accountId as a valid origin for CommunityMemberMgmt - Create and implement EnsureCommunityAccountId. - Add a benchmarking method to it. - Setup parameter for mock. - Setup parameter for runtime. * change(kreivo-runtime): setup communities-related origins * change(kreivo-runtime): remove Nfts pallet from runtime - This is because it's not being used initially * fix(kreivo-runtime): add EnsureRootWithSuccess for SubmitOrigin on CommunityReferenda --------- Co-authored-by: Juan Pablo Gutiérrez Restrepo <[email protected]>
pandres95
added a commit
that referenced
this pull request
Mar 29, 2024
* chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * change(pallet-communities): prepare - configure benchmark helper for pallet-referenda-tracks - fix: missing imports for vec-like structures on benchmarking * change(kreivo-runtime): setup benchmark helper for community tracks pallet * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member (#343) * change(runtime/kreivo): include pallet-communities on dependencies * chore(cargo): update Cargo.lock * feat(pallet-communities): implement structures and storage for governance * feat(pallet-communities): add set_decision_method extrinsic * feat(pallet-communities): implement vote extrinsic * chore(pallet-communities): add initial set of tests for governance section * fix(pallet-communities): lint * chore(cargo): update lockfile * fix(pallet-communities:tests): typo * feat(pallet-communities): better handle type bounds for T::Assets and T::Polls * chore(pallet-communities): refine usage of type aliases * change(pallet-communities:tests): support including multiple communities * feat(pallet-communities): implement unlock call * feat(pallet-communities:tests): extend dynamic communities creation on TestEnvBuilder to create tracks * chore(pallet-communities): test when casting vote on an invalid track / test tie-breaking * fix(pallet-communities): lint * chore(pallet-communities): coverage testing for AssetBalance and NativeBalance voting methods * chore(pallet-communities): add tests for unlock * feat(pallet-communities): implement remove_vote * feat(pallet-communities): implement voting for DecisionMethod::Rank * fix(pallet-communities): lint * chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * chore(cargo): update lockfile * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member * fix(kreivo-runtime): lint --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmark method for unlock * feat(kreivo-runtime): configure benchmark helper for pallet-communities * change(pallet-communities): ensure benchmarks run with default externalities * chore(cargo): update dependencies * fix(kreivo-runtime): set MembershipCollectionId to 0 * fix(pallet-commujnities): remove mock out of tests module * fix(zombienet): add parachain inclusion to relay genesis * feat(pallet-communities): receive community accountId as a valid origin for CommunityMemberMgmt - Create and implement EnsureCommunityAccountId. - Add a benchmarking method to it. - Setup parameter for mock. - Setup parameter for runtime. * change(kreivo-runtime): setup communities-related origins * change(kreivo-runtime): remove Nfts pallet from runtime - This is because it's not being used initially * fix(kreivo-runtime): add EnsureRootWithSuccess for SubmitOrigin on CommunityReferenda --------- Co-authored-by: Juan Pablo Gutiérrez Restrepo <[email protected]>
pandres95
added a commit
that referenced
this pull request
Mar 29, 2024
* chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * change(pallet-communities): prepare - configure benchmark helper for pallet-referenda-tracks - fix: missing imports for vec-like structures on benchmarking * change(kreivo-runtime): setup benchmark helper for community tracks pallet * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member (#343) * change(runtime/kreivo): include pallet-communities on dependencies * chore(cargo): update Cargo.lock * feat(pallet-communities): implement structures and storage for governance * feat(pallet-communities): add set_decision_method extrinsic * feat(pallet-communities): implement vote extrinsic * chore(pallet-communities): add initial set of tests for governance section * fix(pallet-communities): lint * chore(cargo): update lockfile * fix(pallet-communities:tests): typo * feat(pallet-communities): better handle type bounds for T::Assets and T::Polls * chore(pallet-communities): refine usage of type aliases * change(pallet-communities:tests): support including multiple communities * feat(pallet-communities): implement unlock call * feat(pallet-communities:tests): extend dynamic communities creation on TestEnvBuilder to create tracks * chore(pallet-communities): test when casting vote on an invalid track / test tie-breaking * fix(pallet-communities): lint * chore(pallet-communities): coverage testing for AssetBalance and NativeBalance voting methods * chore(pallet-communities): add tests for unlock * feat(pallet-communities): implement remove_vote * feat(pallet-communities): implement voting for DecisionMethod::Rank * fix(pallet-communities): lint * chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * chore(cargo): update lockfile * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member * fix(kreivo-runtime): lint --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmark method for unlock * feat(kreivo-runtime): configure benchmark helper for pallet-communities * change(pallet-communities): ensure benchmarks run with default externalities * chore(cargo): update dependencies * fix(kreivo-runtime): set MembershipCollectionId to 0 * fix(pallet-commujnities): remove mock out of tests module * fix(zombienet): add parachain inclusion to relay genesis * feat(pallet-communities): receive community accountId as a valid origin for CommunityMemberMgmt - Create and implement EnsureCommunityAccountId. - Add a benchmarking method to it. - Setup parameter for mock. - Setup parameter for runtime. * change(kreivo-runtime): setup communities-related origins * change(kreivo-runtime): remove Nfts pallet from runtime - This is because it's not being used initially * fix(kreivo-runtime): add EnsureRootWithSuccess for SubmitOrigin on CommunityReferenda --------- Co-authored-by: Juan Pablo Gutiérrez Restrepo <[email protected]>
olanod
pushed a commit
that referenced
this pull request
Apr 4, 2024
* chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * change(pallet-communities): prepare - configure benchmark helper for pallet-referenda-tracks - fix: missing imports for vec-like structures on benchmarking * change(kreivo-runtime): setup benchmark helper for community tracks pallet * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member (#343) * change(runtime/kreivo): include pallet-communities on dependencies * chore(cargo): update Cargo.lock * feat(pallet-communities): implement structures and storage for governance * feat(pallet-communities): add set_decision_method extrinsic * feat(pallet-communities): implement vote extrinsic * chore(pallet-communities): add initial set of tests for governance section * fix(pallet-communities): lint * chore(cargo): update lockfile * fix(pallet-communities:tests): typo * feat(pallet-communities): better handle type bounds for T::Assets and T::Polls * chore(pallet-communities): refine usage of type aliases * change(pallet-communities:tests): support including multiple communities * feat(pallet-communities): implement unlock call * feat(pallet-communities:tests): extend dynamic communities creation on TestEnvBuilder to create tracks * chore(pallet-communities): test when casting vote on an invalid track / test tie-breaking * fix(pallet-communities): lint * chore(pallet-communities): coverage testing for AssetBalance and NativeBalance voting methods * chore(pallet-communities): add tests for unlock * feat(pallet-communities): implement remove_vote * feat(pallet-communities): implement voting for DecisionMethod::Rank * fix(pallet-communities): lint * chore(kreivo-runtime): subdependencies to pallet-communities * feat(kreivo-runtime): initial parameters for pallet-communities * chore(env): update zombienet configuration files * chore(cargo): update lockfile * wip(pallet-communities): initial parmeters for benchmarks * feat(pallet-communities): bench test for create * fix(runtime/kreivo): set FreezeIdentifier to RuntimeHoldReason on pallet_balance * feat(pallet-communities): benchmark for set_metadata / set_decision_method * feat(pallet-communities): preparing benchmarking helpers for loading memberships and subsequent testings * fix(pallet-communities): check/lint * fix(kreivo-runtime)[wip]: prepare for building with runtime-benchmarks * change(pallet-communities): Added event emitter for removing votes. (#341) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmarking test for vote * fix(pallet-communities): lint * Pallet communities benchmarking runtime parameters (#342) * change(pallet-communities): Added event emitter for removing votes. * fix(runtime-kreivo): increase MaxHolds / increase MaxFreezes - Increased MaxHolds: This is because we included pallet_communities::HoldReasons::Voting to the available HoldReasons - Increase MaxFreezes: This is since you now have funds freezed if you're voting on a community. * feat(pallet-communities): benchmarking test for add_member. --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * change(pallet-communities): sort benchmarks by call order * feat(pallet-communities): benchmarking test for remove_vote * refactor(pallet-communities): externalize factory dependencies from benchmarking * fix(pallet-communities): remove unnecessary imports on benchmarking * refactor(pallet-communities): move BenchmarkHelper to types module * change(kreivo-runtime): configure benchmarking helpers for community related pallets * fix(pallet-communities): gate exporting types::BenchmarkHelper behind feature flag * fix(kreivo-runtime): missing dependencies / missing parameters * feat(pallet-communities): finished benchmarking tests for remove_member, promote_member, and demote_member * fix(kreivo-runtime): lint --------- Co-authored-by: Pablo Andrés Dorado Suárez <[email protected]> * feat(pallet-communities): benchmark method for unlock * feat(kreivo-runtime): configure benchmark helper for pallet-communities * change(pallet-communities): ensure benchmarks run with default externalities * chore(cargo): update dependencies * fix(kreivo-runtime): set MembershipCollectionId to 0 * fix(pallet-commujnities): remove mock out of tests module * fix(zombienet): add parachain inclusion to relay genesis * feat(pallet-communities): receive community accountId as a valid origin for CommunityMemberMgmt - Create and implement EnsureCommunityAccountId. - Add a benchmarking method to it. - Setup parameter for mock. - Setup parameter for runtime. * change(kreivo-runtime): setup communities-related origins * change(kreivo-runtime): remove Nfts pallet from runtime - This is because it's not being used initially * fix(kreivo-runtime): add EnsureRootWithSuccess for SubmitOrigin on CommunityReferenda --------- Co-authored-by: Juan Pablo Gutiérrez Restrepo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.